Skip to content

feat: Updated logic for instructor tabs to match router routing#38380

Open
holaontiveros wants to merge 7 commits intoopenedx:masterfrom
WGU-Open-edX:fix/instructor-tabs
Open

feat: Updated logic for instructor tabs to match router routing#38380
holaontiveros wants to merge 7 commits intoopenedx:masterfrom
WGU-Open-edX:fix/instructor-tabs

Conversation

@holaontiveros
Copy link
Copy Markdown
Contributor

@holaontiveros holaontiveros commented Apr 17, 2026

Description

Instructor tabs need to have URLs that will match the proper routing so same page navigation is possible in the frontend app

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Access the instructor dashboard and try to move from the different tabs if the navigation happens and there's no full reload then the feature is working as expected

Deadline

None

Other information

No database migrations, no runtime changes, no deprecations.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Apr 17, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @holaontiveros!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@holaontiveros holaontiveros changed the title Fix/instructor tabs feat: Updated logic for instructor tabs to match router routing Apr 17, 2026
@diana-villalvazo-wgu diana-villalvazo-wgu moved this from Needs Triage to Ready for Review in Contributions Apr 17, 2026
def get_course_number(self, data):
"""Get course number."""
return data['course'].id.course
return data["course"].id.course
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove any formatting that is not necessary for checks to pass from this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

5 participants