feat: Updated logic for instructor tabs to match router routing#38380
feat: Updated logic for instructor tabs to match router routing#38380holaontiveros wants to merge 7 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @holaontiveros! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| def get_course_number(self, data): | ||
| """Get course number.""" | ||
| return data['course'].id.course | ||
| return data["course"].id.course |
There was a problem hiding this comment.
Could you remove any formatting that is not necessary for checks to pass from this PR?
Description
Instructor tabs need to have URLs that will match the proper routing so same page navigation is possible in the frontend app
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Access the instructor dashboard and try to move from the different tabs if the navigation happens and there's no full reload then the feature is working as expected
Deadline
None
Other information
No database migrations, no runtime changes, no deprecations.