feat: added redirect to new instructor dash

[holaontiveros]

Description

This PR enables by default a redirection from the old instructor dashboard views to the new instructor dashboard front end app

• Course author, staff or anyone with the instructor dashboard access will now see by default the new frontendapp
• A waffle flag is introduced that will enable the legacy dashboard LEGACY_INSTRUCTOR_DASHBOARD

Supporting information

relates to openedx/frontend-base#229

Testing instructions

While having the latest from tutor-mfe at the frontend-base branch:

• Try to access the instructor dashboard
• You should be redirected to the new instructor dash

Deadline

None

Other information

No database migrations, no runtime changes, no deprecations.

---

[openedx-webhooks]

Thanks for the pull request, @holaontiveros!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[wgu-taylor-payne]

Thanks for taking this on! Here are some suggestions and things to think through.

[wgu-taylor-payne]

Thanks for the updates! Here are some further suggestions. Also, I want to make sure the implementation for the flag has more eyes on it than mine. @feanil @sarina.

[sarina]

Looks like enabling this flag is going to cause many instructor unit tests to fail because of 302 response instead of 200

[holaontiveros]

Looks like enabling this flag is going to cause many instructor unit tests to fail because of 302 response instead of 200

This is enabled by default, the flag disables it, but yes a couple of tests break, the tests are related with some email related tests that expected the old section of instructor to exists and even have the a link for email section even if the email section only had a link to the communications MFE

I'm fixing those by getting the flag enabled and letting the tests do their previous functionality

[wgu-taylor-payne]

Thanks, this looks good to me!

[sarina]

[curious] I'm not sure how I would respond to this statement if I was picking up the legacy instructor dash DEPR work (side note, is there a DEPR filed for that yet?). When we no longer have the legacy instructor dash, will these tests be removed, or refactored? If refactored, why would we not just do that now?

[sarina]

OK, talked with Adolfo - it sounds like these tests would exist for now (since the legacy view exists) but would be removed when the legacy views are removed. If that's the case I'd include a TODO in this comment to indicate that these tests will be removed when the DEPR is executed. Please include the DEPR number in your TODO comment.

[holaontiveros]

They should be refactored, this tests have been in a "weird shape" for a while, because many of them expect stuff like "communications" tab to be there, but they don't even check that the communications dash is really there... because that has been on a MFE for a while

They do need to be refactored, but they are 100% unrelated to the feature related to this PR which would create a huge amount of test changes over many different places which should be done one by one and carefully

What I'm looking for with this is literraly keep the current shape of things so everything work as it was and feature work either for deprecation of this flag or as part of the other features starts with the refactoring of all those tests (which should have happened before and I guess it was just postponed)

[sarina]

OK. I guess I was just hoping for a shorter, clearer comment that explains what needs to happen when we drop the legacy views. If the tests can just be deleted I would write something like

# Tests for legacy views. Can be removed when DEPR-XXXX is addressed

If the tests need to be refactored when we drop the legacy view, the comment could be something like

# Tests for legacy views. When DEPR-XXXX is picked up, these tests will require the following changes:
# (change description)

[wgu-taylor-payne]

It would be good to also add that DEPR to the toggle_tickets annotation.

[sarina]

Thanks @holaontiveros !