Bump python-social-auth to upstream's latest master#8599
Bump python-social-auth to upstream's latest master#8599rlucioni merged 1 commit intoopenedx:feature/shibboleth-tpafrom
Conversation
|
Thanks for the pull request, @bradenmacdonald! I've created OSPR-669 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the Github pull request interface. As a reminder, our process documentation is here. |
|
Jenkins, test this please. |
|
👍 |
|
@cpennington This is ready for your review. (It's small) |
|
@bradenmacdonald do you have a link to the diff of the changes? |
|
@bradenmacdonald and/or release notes? that would help evaluate the change. |
|
@cpennington should the platform team or destination team review this? |
|
@sarina The upstream changelog is here. The platform is currently using python-social-auth version 0.2.7, and this bumps it to the upcoming release that will probably be called v 0.2.11. The changelog entries that seem to potentially be relevant to us are:
|
|
@sarina I took a brief skim, but its probably worth destination edx look a little closer. |
|
@bradenmacdonald I've found omab to be very responsive to version bump requests. Have you tried asking him to release 0.2.11 on PyPI? |
|
@rlucioni Good idea. I've just asked him now. |
|
@sarina I see that this has the label "Awaiting Prioritization" Can this be given the necessary priority to make sure it is included in this release? |
|
Renzo has already started reviewing this. I will try my hardest but we are On Tue, Jun 23, 2015 at 7:53 PM, Rob Dolin notifications@github.com wrote:
|
|
Keep in mind if your goal is by the end of the week to make Cypress, we On Tue, Jun 23, 2015 at 9:48 PM, Sarina Canelake sarina@edx.org wrote:
|
There was a problem hiding this comment.
Looks like a new version of python-saml will also be uploaded to PyPI today.
|
FYI, python-social-auth |
|
Thanks for the heads-up @omab. |
85a0225 to
d96da10
Compare
|
I just updated this PR to use 0.2.11 and tested it locally - everything seems great. 3 of the 4 python-saml PRs have been merged so far so I'll watch for a new release of that as well, and then do a final update of this. |
d96da10 to
0395745
Compare
|
A new version of I have switched http://sandbox5.opencraft.com to use these PyPI versions and confirmed that it is still working with our test Shibboleth providers (TestShib and UBC). @Kelketek Can you please take another look and confirm that your +1 stands? Build failure is unrelated and has been fixed on master, but I'd rather not rebase the feature branch while there are four open PRs against it undergoing active review. |
|
@bradenmacdonald 👍 . I'll wait for a look from @Kelketek before merging. |
|
test this please 👍 if the tests pass. |
|
@Kelketek as @bradenmacdonald wrote, the single failing test is unrelated and has been fixed in master. I'm going to go ahead and merge this. |
Bump python-social-auth to upstream's latest master
Summary
The python-social-auth and python-saml projects have merged our changes. This switches us back to using official PyPI releases, which are now compatible with our new SAML backend.
This also pulls in the OAuth2 backend required to support Office 365 logins, therefore providing a replacement for most of #8248.
This is part of the Shibboleth/SSO work and is being merged to the shibboleth-tpa feature branch
Details
Noteworthy changelog entries between python-social-auth version 0.2.7 and 0.2.11:
For python-saml, the only commits added to the PyPI release that weren't previously included in our fork are:
Sandbox:
http://sandbox5.opencraft.com/login has been updated to use the new versions via PyPI (on June 24)
Reviewers
@Kelketek and @rlucioni