Skip to content

feat: Add scripts to output diffs of toggles and settings#447

Merged
sarina merged 3 commits intomainfrom
add-toggles-scripts
Apr 28, 2025
Merged

feat: Add scripts to output diffs of toggles and settings#447
sarina merged 3 commits intomainfrom
add-toggles-scripts

Conversation

@sarina
Copy link
Copy Markdown
Contributor

@sarina sarina commented Apr 24, 2025

These scripts:

  • default-diff.py: Generates a report of what defaults have changed for existing flags, formatted for RST
  • settings-flags-diff.py: Generates the new and removed featuretoggles & settings for this release, compared to the last release, formatted for RST. New featuretoggles & settings will also list their default values.

@sarina sarina requested a review from feoh April 24, 2025 17:28
@sarina sarina marked this pull request as draft April 24, 2025 18:42
@sarina
Copy link
Copy Markdown
Contributor Author

sarina commented Apr 24, 2025

@feoh I'm moving this to draft, becaues I've found another weird thing :sigh:

@sarina
Copy link
Copy Markdown
Contributor Author

sarina commented Apr 24, 2025

The weirdness I found was that in Sumac, the _build/xml directory looks like this:

(8 folders)
references
|-> featuretoggles.xml

but in Teak it looks like:

(8 folders)
references
|-> featuretoggles.xml
xml
|-> references
      |-> featuretoggles.xml

Yep, two files named featuretoggles.xml and it appears only the second one is accurate. Still trying to get to the bottom of this but for now I think I've generated the files:

@feoh
Copy link
Copy Markdown

feoh commented Apr 24, 2025

Thanks so much for looking into this! I'm on vacation tomorrow and will be back on Monday.

Copy link
Copy Markdown

@feoh feoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work. Thank you!

@sarina sarina force-pushed the add-toggles-scripts branch from a14884a to 81c1657 Compare April 25, 2025 15:12
@sarina sarina force-pushed the add-toggles-scripts branch from 81c1657 to 4847c74 Compare April 25, 2025 19:26
@sarina sarina marked this pull request as ready for review April 25, 2025 19:29
@sarina sarina merged commit 97f4f6c into main Apr 28, 2025
2 checks passed
@sarina sarina deleted the add-toggles-scripts branch April 28, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants