feat: drop Python 3.8 and add Python 3.12 support#514
Merged
feanil merged 1 commit intoopenedx:masterfrom Nov 14, 2024
Merged
Conversation
feanil
reviewed
Nov 14, 2024
Contributor
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
One thing to fix but then I think this is good for me to merge/release.
requirements/common_constraints.txt
Outdated
| importlib-metadata<7 | ||
| # Adding pin to avoid any major upgrade | ||
| # Issue for unpinning: https://github.com/openedx/edx-platform/issues/35265 | ||
| pymongo<4.4.1 |
Contributor
There was a problem hiding this comment.
The only reason this repo depends on pymongo is because of opaque-keys. You should let that repo set any restrictions on pymongo for our testing and not constrain it here.
Contributor
Author
There was a problem hiding this comment.
sounds good! I have removed the pymongo constraint here.
- Dropped support for Python 3.8 and added support for Python 3.12. - Removed importlib-metadata<7 pin from constraints as it's unpin issue was closed. - Updated pylintrc file with latest version of edx-lint. - Fixed app_label error for model named CourseAllowPIISharingInLTIFlag. - Released a new version.
Faraz32123
force-pushed
the
faraz/feat-drop_python3.8_and_add_support_for_python_3.12
branch
from
0db0dac to
5beb2e1
Compare
feanil
approved these changes
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the below items: