Fix Python and JavaScript (Karma) tests for Problem XBlock#151
Fix Python and JavaScript (Karma) tests for Problem XBlock#151irtazaakram merged 3 commits intoproblemblockfrom
Conversation
3c433b8 to
e0497fd
Compare
kdmccormick
left a comment
There was a problem hiding this comment.
I'm still working through the review, here are my comments so far
9c42194 to
c52b875
Compare
264fadc to
9435393
Compare
6599a44 to
363ce85
Compare
There was a problem hiding this comment.
@irtazaakram , glad to see tests are passing. This looks fine to merge into the problemblock branch if that would be helpful for development, just please incorporate my XBlockUserState TODO comment, if you agree. No need to wait for my approval on this one.
However, I don't want to add XModuleMixin, XModuleToXBlockMixin, or XmlMixin to this repo if possible. They are legacy tech debt and I think that, with some refactoring, we will be able to get everything working without relying on them. Or, if we do merge them in temporarily, I'd like to refactor them away as soon as possible.
If you want to keep them in this PR, could you add TODO comments about removing each of them? Let me know if you walk to talk about strategies for factoring them out later.
9435393 to
f51be3d
Compare
9721222 to
c50800d
Compare
f51be3d to
254a524
Compare
f771708 to
fe1810d
Compare
254a524 to
f0ba9ee
Compare
fe1810d to
c4cd4db
Compare
f0ba9ee to
ad06e4e
Compare
9e05b31 to
1999b3d
Compare
Summary
This PR fixes the Python and JavaScript (Karma) tests for the newly extracted Problem (CAPA) XBlock.
Context
What Changed
tests/to align with the new directory structure.npm build.Notes