Skip to content

Fix Python and JavaScript (Karma) tests for Problem XBlock#151

Merged
irtazaakram merged 3 commits intoproblemblockfrom
fix-problemblock
Mar 2, 2026
Merged

Fix Python and JavaScript (Karma) tests for Problem XBlock#151
irtazaakram merged 3 commits intoproblemblockfrom
fix-problemblock

Conversation

@irtazaakram
Copy link
Member

@irtazaakram irtazaakram commented Feb 3, 2026

Summary

This PR fixes the Python and JavaScript (Karma) tests for the newly extracted Problem (CAPA) XBlock.

Context

What Changed

  • Python Tests: Fixed import paths and module references in tests/ to align with the new directory structure.
  • Javascript Tests: Added Karma configuration and Webpack config.
  • Setup: Changed how xblocks-contribute is installed by requiring npm build.

Notes

  • Pylint cleanup and documentation updates are out of scope for this PR and will be addressed in Fix Quality and Docs tests for Problem XBlock #153 and that will be merged into this branch for it to be ready.
  • The primary goal of this PR is to get the test suite green to unblock integration.

@irtazaakram irtazaakram changed the title fix: python & javascript tests Fix Python and JavaScript (Karma) tests for Problem Xblock Feb 3, 2026
@irtazaakram irtazaakram changed the title Fix Python and JavaScript (Karma) tests for Problem Xblock Fix Python and JavaScript (Karma) tests for Problem XBlock Feb 3, 2026
@irtazaakram irtazaakram self-assigned this Feb 3, 2026
@irtazaakram irtazaakram moved this to 👀 In review in Aximprovements Team Feb 3, 2026
@irtazaakram irtazaakram force-pushed the fix-problemblock branch 2 times, most recently from 3c433b8 to e0497fd Compare February 3, 2026 14:33
@kdmccormick kdmccormick self-requested a review February 4, 2026 14:16
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still working through the review, here are my comments so far

Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@irtazaakram , glad to see tests are passing. This looks fine to merge into the problemblock branch if that would be helpful for development, just please incorporate my XBlockUserState TODO comment, if you agree. No need to wait for my approval on this one.

However, I don't want to add XModuleMixin, XModuleToXBlockMixin, or XmlMixin to this repo if possible. They are legacy tech debt and I think that, with some refactoring, we will be able to get everything working without relying on them. Or, if we do merge them in temporarily, I'd like to refactor them away as soon as possible.

If you want to keep them in this PR, could you add TODO comments about removing each of them? Let me know if you walk to talk about strategies for factoring them out later.

Copy link
Contributor

@salman2013 salman2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irtazaakram irtazaakram merged commit eef1737 into problemblock Mar 2, 2026
12 of 13 checks passed
@irtazaakram irtazaakram deleted the fix-problemblock branch March 2, 2026 11:28
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Aximprovements Team Mar 2, 2026
irtazaakram added a commit that referenced this pull request Mar 2, 2026
* fix: add problem xblock

* fix: python and javascript tests for problem xblock (#151)

* fix: quality & doc tests (#153)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants