[WIP] Use multi-stage build for CSharp#82
Merged
alexellis merged 2 commits intoopenfaas:masterfrom Sep 8, 2017
Merged
Conversation
Signed-off-by: Robbie Page <rob@rorpage.com>
Member
|
Thanks for this. Can you try this with a new image name including pushing to the hub? |
Member
|
@rorpage did you say this is working now? |
Member
|
I got: Right - I remember the issue. Please change the hard-coded fprocess in the Golang code with this PR. It'll fix everything. Change it here: |
Signed-off-by: Robbie Page <rob@rorpage.com>
Contributor
Author
|
@alexellis This has been tested locally with the |
alexellis
approved these changes
Sep 8, 2017
Member
alexellis
left a comment
There was a problem hiding this comment.
Good work :-) this will make a difference for people
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robbie Page rob@rorpage.com
Description
I have updated the csharp template to use multi-stage. The first stage is using the dotnet SDK, and the second uses the runtime.
Motivation and Context
The dotnet images are rather large so by implementing a multi-stage build, we decrease the end function image.
#53
How Has This Been Tested?
I updated my template locally, created a new csharp function, built, deployed, and invoked the function and saw that everything ran as expected.
Types of changes
Checklist:
git commit -s