Skip to content

feat: add name as a filter for ListStores #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jpadilla merged 7 commits into from
Dec 17, 2024
Merged

feat: add name as a filter for ListStores #211

jpadilla merged 7 commits into from
Dec 17, 2024

Conversation

@kalleep
Copy link
Contributor

@kalleep kalleep commented Nov 14, 2024 •
edited
Loading

Description

While the this rfc is not yet accepted its still useful to implement the ability to filter stores by name for ListStores requests.

References

Part of openfga/rfcs#27

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)

@kalleep kalleep requested review from a team as code owners November 14, 2024 10:46
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 14, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@kalleep
Copy link
Contributor Author

kalleep commented Nov 14, 2024 •
edited
Loading

Draft pr for the actual implementation can be found here openfga/openfga#2103

@kalleep kalleep mentioned this pull request Nov 14, 2024
Merged
4 tasks
jpadilla
jpadilla requested changes Nov 27, 2024
View reviewed changes
rhamzeh
rhamzeh reviewed Dec 2, 2024
View reviewed changes
jpadilla
jpadilla previously approved these changes Dec 6, 2024
View reviewed changes
@kalleep kalleep requested review from jpadilla and rhamzeh December 16, 2024 09:43
@rhamzeh rhamzeh mentioned this pull request Dec 16, 2024
Merged
4 tasks
@jpadilla
Copy link
Member

jpadilla commented Dec 17, 2024

@kalleep we had to fix something else in #214 mind updating again?

@jpadilla jpadilla merged commit 6e048d8 into openfga:main Dec 17, 2024
6 checks passed
@jimmyjames jimmyjames mentioned this pull request Mar 26, 2025
Closed
6 tasks
This was referenced Mar 26, 2025
Closed
Closed
Closed
Closed
@rhamzeh rhamzeh mentioned this pull request Mar 26, 2025
Closed
1 task
@varkart varkart mentioned this pull request Aug 7, 2025
Closed
4 tasks
aaguiarz pushed a commit that referenced this pull request Jan 13, 2026
@kalleep @aaguiarz
feat: add name as a filter for ListStores (#211)
c4c6f2d 
* Add name as a filter for ListStores

* Add validation and openapi annotations

* Skip validation on empty name

* Add description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpadilla jpadilla jpadilla approved these changes

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kalleep @jpadilla @rhamzeh