Address undefined behavior related to hashing enums#1045
Merged
dsuponitskiy merged 1 commit intoopenfheorg:devfrom Sep 24, 2025
Merged
Address undefined behavior related to hashing enums#1045dsuponitskiy merged 1 commit intoopenfheorg:devfrom
dsuponitskiy merged 1 commit intoopenfheorg:devfrom
Conversation
Collaborator
Author
|
If you'll excuse the noise of a Google-internal stack trace, here's the ubsan error: |
pascoec
approved these changes
Aug 27, 2025
Contributor
|
@dsuponitskiy Please add an issue for this PR and also review the changes. |
dsuponitskiy
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hashing of this untyped enum was flagged as undefined behavior in v1.4.0 by ubsan. The compiler is allowed to pick the type of the enum, and static_cast from an int to the enum (as performed by unordered_map) is UB.