Fix incomplete Issue #110 - change PREMode default to NOT_SET#1124
Fix incomplete Issue #110 - change PREMode default to NOT_SET#1124BurakKTopal wants to merge 1 commit intodevfrom
Conversation
|
Yuriy asked me to fix your original PR, so please do not reopen this one. We don’t need duplicate PRs. In addition, I’ve already started two extensive CI runs for the PR I opened. |
|
@dsuponitskiy and @yspolyakov, I understand and respect the policy. If I may comment that I find the steps taken unusual: taking over someone else's work like this. I would have valued it a lot more to let me do it end-to-end and obtain full credits. |
Hi @BurakKTopal Sorry you feel this way but I want to provide several clarifications to explain that your statement is not accurate.
Thank you for understanding. Yuriy |
This PR replaces this original PR and fixes #110
The original fix in commit 64ed308 never worked because PREMode defaulted to INDCPA, not NOT_SET. This caused GetParamsPK() to always return Q×P basis for HYBRID, even when PRE is not needed.
Changes: