Skip to content

PKE class clean-up#903

Merged
pascoec merged 1 commit intotmp-devfrom
902-replace-dcrtpoly
Nov 22, 2024
Merged

PKE class clean-up#903
pascoec merged 1 commit intotmp-devfrom
902-replace-dcrtpoly

Conversation

@dsuponitskiy
Copy link
Copy Markdown
Collaborator

@dsuponitskiy dsuponitskiy commented Oct 31, 2024 •
edited by yspolyakov
Loading

  • Replaced the DCRTPoly type with Element in template functions
  • Made ParamsGenBGVRNS(), ParamsGenCKKSRNS() and ParamsGenBFVRNS() non-virtual in base-scheme.h

@dsuponitskiy-duality
Replaced the DCRTPoly type with Element in template functions, made P…
a78e741 
…aramsGenBGVRNS(), ParamsGenCKKSRNS() and ParamsGenBFVRNS() non-virtual in base-scheme.h
@dsuponitskiy dsuponitskiy added the bug Something isn't working label Oct 31, 2024
@dsuponitskiy dsuponitskiy added this to the Release 1.2.4 milestone Oct 31, 2024
@dsuponitskiy dsuponitskiy self-assigned this Oct 31, 2024
@dsuponitskiy dsuponitskiy linked an issue Oct 31, 2024 that may be closed by this pull request
Replace "DCRTPoly" with "Element" in some files #902
Closed
@yspolyakov yspolyakov changed the title Replaced the DCRTPoly type with Element in template functions, made ParamsGenBGVRNS(), ParamsGenCKKSRNS() and ParamsGenBFVRNS() non-virtual in base-scheme.h PKE class clean-up Nov 21, 2024
@yspolyakov yspolyakov added the cleanup Code cleanup label Nov 21, 2024
@dsuponitskiy dsuponitskiy changed the base branch from dev to tmp-dev November 22, 2024 16:02
@pascoec pascoec merged commit b214596 into tmp-dev Nov 22, 2024
@dsuponitskiy dsuponitskiy deleted the 902-replace-dcrtpoly branch December 4, 2024 20:57
yspolyakov pushed a commit that referenced this pull request Apr 2, 2025
@dsuponitskiy @dsuponitskiy-duality
Replaced the DCRTPoly type with Element in template functions, made P…
28def54 
…aramsGenBGVRNS(), ParamsGenCKKSRNS() and ParamsGenBFVRNS() non-virtual in base-scheme.h (#903)

Co-authored-by: Dmitriy Suponitskiy <dsuponitskiy@dualitytech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yspolyakov yspolyakov yspolyakov approved these changes

@pascoec pascoec pascoec approved these changes

Assignees

@dsuponitskiy dsuponitskiy

Labels

bug Something isn't working cleanup Code cleanup

Projects

None yet

Milestone

Release 1.3.0

Development

Successfully merging this pull request may close these issues.

Replace "DCRTPoly" with "Element" in some files

4 participants

@dsuponitskiy @yspolyakov @pascoec @dsuponitskiy-duality