Conversation
…ns to pke/unittest as it is a collection of special utilities
dsuponitskiy
force-pushed
the
869-move-schemeswitching-serializer
branch
from
d23c870 to
2333801
Compare
Collaborator
andreea-alexandru
left a comment
andreea-alexandru
left a comment
There was a problem hiding this comment.
Looks good, but please add a paragraph in SCHEME_SWITCHING_CAPABILITY.md to say that an example for serializing scheme switching is given in scheme-switching-serial.cpp and users should also update src/pke/unittest/utils/schemeswitching-data-serializer.h if they want to specify other filenames.
yspolyakov
pushed a commit
that referenced
this pull request
Apr 2, 2025
…ns to pke/unittest as it is a collection of special utilities (#916) * Moved schemeswitching-data-serializer.h from pke/include/scheme/ckksrns to pke/unittest as it is a collection of special utilities * Addressed code review comments --------- Co-authored-by: Dmitriy Suponitskiy <dsuponitskiy@dualitytech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.