Massive changes to standardize the use of uint32_t: phase 2 #924
Merged
Massive changes to standardize the use of uint32_t: phase 2 #924
Conversation
…wo() to ReduceRotation(), some auxilliary changes
…e error handling, changes to GetCollapsedFFTParams() and Degree(), additional refactoring of CoeffDecodingCollapse()
…n CoeffEncodingOneLevel() and CoeffDecodingOneLevel() with a variable, improvements to CoeffEncodingCollapse()
dsuponitskiy
changed the title
pascoec
approved these changes
Jan 17, 2025
yspolyakov
pushed a commit
that referenced
this pull request
Apr 2, 2025
* Refactored GetCollapsedFFTParams and SelectLayers(), added IsPowerOfTwo() to ReduceRotation(), some auxilliary changes * Refactored CoeffDecodingCollapse() * The scope of SelectLayers() is limited to ckksrns-utils.cpp only, some error handling, changes to GetCollapsedFFTParams() and Degree(), additional refactoring of CoeffDecodingCollapse() * Some corrections to CoeffEncodingCollapse() * Added some cast, replaced multiple calculations of std::log2(slots) in CoeffEncodingOneLevel() and CoeffDecodingOneLevel() with a variable, improvements to CoeffEncodingCollapse() * Finished refactoring CoeffEncodingCollapse() --------- Co-authored-by: Dmitriy Suponitskiy <dsuponitskiy@dualitytech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.