Merged
Conversation
…unctions (#939) Co-authored-by: Dmitriy Suponitskiy <dsuponitskiy@dualitytech.com>
* First cut of std thread mutual exclusion * distributiongenerator thread mutual exclusion * Diagnostic output for Precompute phases. * revert to minimal implementation that works under std::thread, with proper single-threaded initialization * remove lazy precompute map searches * Control the usage of C++ threads for PRNG from CMakeLists.txt * Restored lazy precompute map searches --------- Co-authored-by: Jack Bates <jbates@dualitytech.com> Co-authored-by: Dmitriy Suponitskiy <dsuponitskiy@dualitytech.com>
Collaborator
|
I have reviewed, built, and tested the threading changes. I have reviewed the release notes. This looks good to me, so I am approving. |
jbates-duality
approved these changes
Mar 21, 2025
Collaborator
jbates-duality
left a comment
jbates-duality
left a comment
There was a problem hiding this comment.
I have reviewed these changes, and tested the threading logic. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.