Fixed failures in openfhe-python tests linked with clang++-18#972
Merged
Fixed failures in openfhe-python tests linked with clang++-18#972
Conversation
dsuponitskiy
force-pushed
the
971-fix-test-failures-for-clang
branch
from
cc300d2 to
77387b2
Compare
pascoec
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dynamic_cast didn't work. only after removing "final" from ILDCRTParams, dynamic_cast started working.
this suggests that clang handles "final" differently in templates. most likely, it optimizes some things more aggressively, which affects RTTI and base class behavior (especially in templates).
NOTE: the test fails with the -O3 optimization flag, but passes with -O0 or when linked in Debug mode