Skip to content

Replaced dynamic_cast with typeid() to fix failures in unittests linked with clang++-18 and running on MacOS #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pascoec merged 1 commit into from
May 6, 2025
Merged

Replaced dynamic_cast with typeid() to fix failures in unittests linked with clang++-18 and running on MacOS #975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/core/include/lattice/hal/default/ilparams.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,12 @@ class ILParamsImpl final : public ElemParams<IntType> {
* DCRTPoly, False otherwise
*/
bool operator==(const ElemParams<IntType>& rhs) const override {
if (!dynamic_cast<const ILParamsImpl<IntType>*>(&rhs))
// ATTENTION: dynamic_cast was replaced with typeid() to fix failures in unittests linked with clang++-18 and running on MacOS
// ===========================================================================================================================
// see a similar change in "operator==()" for "class ILDCRTParams" (ildcrtparams.h)
if (typeid(rhs) != typeid(const ILParamsImpl<IntType>))
return false;

return ElemParams<IntType>::operator==(rhs);
}

Expand Down