Merged
Conversation
9 tasks
yspolyakov
commented
May 7, 2025
| "Prime moduli size must generally be greater than 19, especially for larger multiplicative depth."; | ||
| errorMsg += "Consider increasing the scaling factor (scalingModSize) or the register word size."; | ||
| errorMsg += "Also, feel free to use COMPOSITESCALINGMANUAL at your own risk."; | ||
| std::string errorMsg = "Prime moduli is too small. Its size must generally be greater than 19,"; |
Contributor
Author
There was a problem hiding this comment.
Prime moduli are too small - moduli is plural. Please change to plural everywhere here.
yspolyakov
commented
May 7, 2025
dsuponitskiy
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation updates + fix in iterative CKKS bootstrapping example for CKKS composite scaling.