Skip to content

Suggestion de Claude que l'on gagnerait à regarder #1359

@benjello

Description

@benjello

Suggestion de Claude :

  Issue found in in_yaml_test_reform.py:15:
  reformed_parameters=dict,  # Should be: reformed_parameters: dict
  This is a type annotation bug - =dict sets the default to the dict class itself, not an empty dict. It should be : dict for type hint or = None for a default value.

  Also in apply() method (line 26-27): The modify_parameters function ignores local_parameters and completely replaces the parameter tree. This seems intentional but the docstring says "similar to a parameter tree" - might be worth clarifying if this fully replaces or merges parameters.

Originally posted by @benoit-cty in #1358 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions