fix: Surface underlying import errors for SAM3 backend availability checks#487
Merged
fix: Surface underlying import errors for SAM3 backend availability checks#487
Conversation
…hecks When SAM3 backend imports fail, the error messages now include the actual underlying import exception. This helps users diagnose issues like DLL conflicts or missing dependencies, rather than just seeing a generic 'pip install' message. Addresses opengeos/geoai#519
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances error reporting for SAM3 backend import failures by capturing and surfacing the underlying ImportError exceptions. When users encounter import issues (e.g., DLL conflicts, pyarrow version mismatches, or missing dependencies), they now see the actual error details instead of just generic installation instructions.
Changes:
- Capture ImportError exceptions when checking SAM3_META and SAM3_TRANSFORMERS availability
- Include underlying exception details in error messages raised during backend initialization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🚀 Deployed on https://69854a2b432ab5f6314c9796--opengeos.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When SAM3 backend imports fail, the error messages now include the actual underlying import exception. This helps users diagnose issues like DLL conflicts, pyarrow version mismatches, or missing dependencies, rather than just seeing a generic 'pip install segment-geospatial[samgeo3]' message.
Related Issue
Addresses opengeos/geoai#519
Changes
ImportErrorexception when settingSAM3_META_AVAILABLEandSAM3_TRANSFORMERS_AVAILABLEflagsImportErrorExample
Before this change:
After this change (when e.g., a DLL conflict exists):
This makes it much easier for users to identify and resolve the root cause of import failures.