Open
Conversation
Contributor
|
do you mind sharing what's the issue? i might be able to help |
Contributor
Author
@seaerchin it says tailwind not found in node_modules for studio - TBH I also don't really know why. Tried deleting the repo and reckoning+npm ci, but still couldn't fix it... :( |
|
This pull request has been stale for more than 30 days! Could someone please take a look at it @opengovsg/isomer-engineers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For some reason, setting up the codebase from scratch again caused a tailwind import issue
Solution
Bug Fixes:
tailwindcss/colours.jsinstead oftailwindcss/coloursNote
Low Risk
Primarily build/config import-path fixes and a small refactor to source colors from components; runtime impact should be limited to Tailwind build success and potential missing CSS utilities in the preview bundle.
Overview
Fixes Tailwind setup/import breakages by switching Tailwind ESM imports to explicit
.jsentrypoints (e.g.tailwindcss/plugin.js,tailwindcss/defaultTheme.js,tailwindcss/colors.js) across presets and template/storybook configs.Studio no longer imports
tailwindcss/colorsdirectly; instead@opengovsg/isomer-componentsnow re-exportsisomerColorsfrom the Next preset and Studio’s contrast-checking logic uses that shared token (isomerColors.base.content.DEFAULT).The generated Studio preview Tailwind CSS bundle is updated, removing a few previously emitted utilities (e.g.
end-1,!inline,max-h-16,gap-x-2,pl-1, and some responsive variants).Written by Cursor Bugbot for commit 230cf6f. This will update automatically on new commits. Configure here.