oh-input: Fix parts of value appended as unit for complex formatted states by Copilot · Pull Request #4122 · openhab/openhab-webui

Copilot · 2026-04-22T05:25:41Z

Agent-Logs-Url: https://github.com/openhab/openhab-webui/sessions/d09384d7-c688-4af4-9268-80aa8e27240f Co-authored-by: florian-h05 <73423173+florian-h05@users.noreply.github.com>

relativeci · 2026-04-22T13:27:36Z

#5367 Bundle Size — 13.84MiB (~-0.01%).

e41c88e(current) vs 6f9bab9 main#5359(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics no changes

	Current #5367	Baseline #5359
Initial JS	`1.41MiB`	`1.41MiB`
Initial CSS	`0B`	`0B`
Cache Invalidation	`16.18%`	`16.18%`
Chunks	`697`	`697`
Assets	`816`	`816`
Modules	`2818`	`2818`
Duplicate Modules	`0`	`0`
Duplicate Code	`0%`	`0%`
Packages	`126`	`126`
Duplicate Packages	`1`	`1`

Bundle size by type

1 change

1 improvement

	Current #5367	Baseline #5359
JS	`11.53MiB` (`~-0.01%`)	`11.53MiB`
CSS	`902.12KiB`	`902.12KiB`
IMG	`638.41KiB`	`638.41KiB`
Fonts	`526.1KiB`	`526.1KiB`
Media	`295.6KiB`	`295.6KiB`
Other	`847B`	`847B`

Bundle analysis report Branch copilot/fix-api-400-oh-input-car... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

Signed-off-by: Florian Hotze <dev@florianhotze.com>

florian-h05

LGTM!

florian-h05 · 2026-04-22T13:56:55Z

@jsjames Can you please review this PR? My approval doesn't "count" as I contributed to that PR and Copilot acted on my behalf.

Signed-off-by: Florian Hotze <dev@florianhotze.com>

mherwege · 2026-04-23T06:44:09Z

I am still not sure we solve all cases. I didn't test it, but look at the followign examples.

This is a valid pattern: %.0f kW is the power. Reading the code, I believe we will have power as the unit, while it should be kW.
I am not even sure %.0f %unit% is the power will correctly extract %unit%.

This is tricky, but in general text after the last pattern is allowed and would be shown verbatim. And you should assume the unit is always following the value.

…t, not last token Agent-Logs-Url: https://github.com/openhab/openhab-webui/sessions/7cd78c01-d244-4e21-9102-94a2fed71b67 Co-authored-by: florian-h05 <73423173+florian-h05@users.noreply.github.com>

florian-h05 · 2026-04-23T14:43:46Z

Better now @mherwege?

mherwege · 2026-04-23T15:41:34Z

Better now @mherwege?

Yes. LGTM now. I think there still is one case where it would fail: if there is no unit in the pattern, but some text behind the value. But the only way to avoid that would be to check if the position after the value is %unit or a valid unit pattern. Having a definitive check on that would be very difficult (there is some code already for the UI unit validation, but it still allows any string as it is difficult to cover all possible allowed combinations).

jsjames · 2026-04-24T13:27:31Z

I added one additional test case / fix and had copilot suggest the fix.

Also, I had to modify vitest in order to run due to localStorage.getItem. Did this work correctly for you without that?

florian-h05 · 2026-04-24T14:51:39Z

I didn't need that and also wonder why this should be needed.

CI also didn't need it.

this is the error I get without that code:

(node:98844) Warning: `--localstorage-file` was provided without a valid path (Use `node --trace-warnings ...` to show where the warning was created) ❯ src/components/widgets/system/oh-input.test.ts (0 test) ⎯⎯⎯⎯⎯⎯ Failed Suites 1 ⎯⎯⎯⎯⎯⎯⎯ FAIL src/components/widgets/system/oh-input.test.ts [ src/components/widgets/system/oh-input.test.ts ] TypeError: localStorage.getItem is not a function ❯ getTimelineLayersStateFromStorage node_modules/@vue/devtools-kit/dist/index.js:2272:30 ❯ initStateFactory node_modules/@vue/devtools-kit/dist/index.js:2565:26 ❯ node_modules/@vue/devtools-kit/dist/index.js:2569:68 ❯ src/js/stores/useUserStore.ts:1:1 1| import { defineStore } from 'pinia' | ^ 2| import { ref } from 'vue'

I was using node@25. Once I backed down to node@24, things work. I'll update.

florian-h05 · 2026-04-24T14:52:27Z

    expect(value).toBe('20')
  })

+  it('does not strip a unit that only matches mid-string', () => {


I don't understand that test case.
How should s be extracted as a unit from 125 ms? In that case, ms should be extracted as unit.

correct "ms" should be the right unit, but the current logic returns "m"

Why does the current logic return s as unit when it’s ms?
Display state vs state?!

In that case the issue imo is in the unit extraction and not the value extraction.

agree - i wasn't following the logic (and relied too much on copilot). I'll revert the change.

florian-h05 · 2026-04-24T19:40:49Z

Please no force pushes!!
A “clean” commit history doesn’t matter in PRs since it is squashed anyway, but force pushing deletes the review progress.

Initial plan

1e758fe

Copilot AI assigned Copilot and florian-h05 Apr 22, 2026

Copilot started work on behalf of florian-h05 April 22, 2026 05:25 View session

Copilot AI linked an issue Apr 22, 2026 that may be closed by this pull request

API responds 400 with oh-input-card #4027

Open

Copilot AI and others added 2 commits April 22, 2026 05:34

Fix oh-input unit extraction for Number:Time display state

8ea9641

Agent-Logs-Url: https://github.com/openhab/openhab-webui/sessions/d09384d7-c688-4af4-9268-80aa8e27240f Co-authored-by: florian-h05 <73423173+florian-h05@users.noreply.github.com>

Address review feedback for oh-input unit extraction tests

4352c27

Agent-Logs-Url: https://github.com/openhab/openhab-webui/sessions/d09384d7-c688-4af4-9268-80aa8e27240f Co-authored-by: florian-h05 <73423173+florian-h05@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix API responding 400 with oh-input-card~~ Prevent oh-input-card from appending pseudo-units for Number:Time display formats Apr 22, 2026

Copilot finished work on behalf of florian-h05 April 22, 2026 05:41

Copilot AI requested a review from florian-h05 April 22, 2026 05:41

Copilot started work on behalf of florian-h05 April 22, 2026 13:06 View session

Copilot finished work on behalf of florian-h05 April 22, 2026 13:10

Copilot started work on behalf of florian-h05 April 22, 2026 13:13 View session

Copilot finished work on behalf of florian-h05 April 22, 2026 13:22

florian-h05 force-pushed the copilot/fix-api-400-oh-input-card branch from 448b727 to 4352c27 Compare April 22, 2026 13:25

florian-h05 added 3 commits April 22, 2026 15:42

Fallback to Item's unit if no display unit available

441f81d

Signed-off-by: Florian Hotze <dev@florianhotze.com>

Add more tests

13339ad

Signed-off-by: Florian Hotze <dev@florianhotze.com>

Fix value extraction might not strip of complex units correctly

6b2d31b

Signed-off-by: Florian Hotze <dev@florianhotze.com>

florian-h05 approved these changes Apr 22, 2026

View reviewed changes

florian-h05 changed the title ~~Prevent oh-input-card from appending pseudo-units for Number:Time display formats~~ oh-input: Fix parts of value appended as unit for complex formatted states Apr 22, 2026

florian-h05 added bug Something isn't working main ui Main UI labels Apr 22, 2026

florian-h05 marked this pull request as ready for review April 22, 2026 13:56

florian-h05 requested review from ghys and jsjames as code owners April 22, 2026 13:56

florian-h05 mentioned this pull request Apr 22, 2026

API responds 400 with oh-input-card #4027

Open

mherwege reviewed Apr 22, 2026

View reviewed changes

Comment thread bundles/org.openhab.ui/web/src/components/widgets/system/oh-input.vue Outdated

Address comment from @mherwege

3782b9d

Signed-off-by: Florian Hotze <dev@florianhotze.com>

mherwege reviewed Apr 22, 2026

View reviewed changes

Comment thread bundles/org.openhab.ui/web/src/components/widgets/system/oh-input.test.ts Outdated

Address comment from @mherwege

a4a199f

Signed-off-by: Florian Hotze <dev@florianhotze.com>

Copilot started work on behalf of florian-h05 April 23, 2026 13:03 View session

Copilot finished work on behalf of florian-h05 April 23, 2026 13:05

Copilot AI requested a review from florian-h05 April 23, 2026 13:05

Copilot started work on behalf of florian-h05 April 23, 2026 13:06 View session

fix(oh-input): return token immediately after format specifier as uni…

e41c88e

…t, not last token Agent-Logs-Url: https://github.com/openhab/openhab-webui/sessions/7cd78c01-d244-4e21-9102-94a2fed71b67 Co-authored-by: florian-h05 <73423173+florian-h05@users.noreply.github.com>

Copilot finished work on behalf of florian-h05 April 23, 2026 13:12

jsjames force-pushed the copilot/fix-api-400-oh-input-card branch from 84a8b0f to 291fff9 Compare April 24, 2026 14:48

florian-h05 requested changes Apr 24, 2026

View reviewed changes

Copilot started work on behalf of florian-h05 April 24, 2026 14:52 View session

Copilot AI requested a review from florian-h05 April 24, 2026 14:53

jsjames force-pushed the copilot/fix-api-400-oh-input-card branch from e232cc5 to e41c88e Compare April 24, 2026 17:59

Uh oh!

Conversation

Copilot AI commented Apr 22, 2026 • edited by florian-h05 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

relativeci Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

#5367 Bundle Size — 13.84MiB (~-0.01%).

Uh oh!

florian-h05 left a comment

Choose a reason for hiding this comment

Uh oh!

florian-h05 commented Apr 22, 2026

Uh oh!

Uh oh!

Uh oh!

mherwege commented Apr 23, 2026

Uh oh!

florian-h05 commented Apr 23, 2026

Uh oh!

mherwege commented Apr 23, 2026

Uh oh!

jsjames commented Apr 24, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

florian-h05 commented Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Apr 22, 2026 •

edited by florian-h05

Loading

relativeci Bot commented Apr 22, 2026 •

edited

Loading