This repository was archived by the owner on Jul 24, 2023. It is now read-only.
More cleanup #139
Merged
More cleanup #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@marcoceppi Would you mind merging my long standing PR? |
marcoceppi
suggested changes
Aug 9, 2018
Member
marcoceppi
left a comment
marcoceppi
left a comment
There was a problem hiding this comment.
Anywhere you've made the change from array() to shorthand, make sure, if it's a multi-line array that the last element has a trailing ,
|
|
||
| $store_types = array("Filesystem" => "Auth_OpenID_FileStore", | ||
| $store_types = [ | ||
| "Filesystem" => "Auth_OpenID_FileStore", |
examples/server/setup.php
Outdated
| "MySQL" => "Auth_OpenID_MySQLStore", | ||
| "PostgreSQL" => "Auth_OpenID_PostgreSQLStore", | ||
| "SQLite" => "Auth_OpenID_SQLiteStore"); | ||
| "SQLite" => "Auth_OpenID_SQLiteStore" |
Member
There was a problem hiding this comment.
If we're going to do this, lets also use the dangling ,
| $headers = array( | ||
| 'X-XRDS-Location: '.$xrdsurl); | ||
| $headers = [ | ||
| 'X-XRDS-Location: '.$xrdsurl |
examples/server/lib/common.php
Outdated
| 'country' => 'ES', | ||
| 'language' => 'eu', | ||
| 'timezone' => 'America/New_York'); | ||
| 'timezone' => 'America/New_York' |
| 'using consumer support, you should still be able to operate ' . | ||
| 'securely when the users are communicating with a ' . | ||
| 'well-implemented server.')); | ||
| 'well-implemented server.' |
examples/consumer/common.php
Outdated
| $pape_policy_uris = [ | ||
| PAPE_AUTH_MULTI_FACTOR_PHYSICAL, | ||
| PAPE_AUTH_MULTI_FACTOR, | ||
| PAPE_AUTH_PHISHING_RESISTANT |
admin/texttest.php
Outdated
| 'insecure-rand', | ||
| 'thorough', | ||
| 'extra-tests='); | ||
| 'extra-tests=' |
Contributor
Author
|
Wow... That was really fast. Will update the PR to match latest code (changes were done by PHPStorm back then) |
marcoceppi
approved these changes
Apr 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.