8374948: [8u] saproc & jsig builds add duplicate linker flags on Darwin/MacOS

[gnu-andrew]

This patch breaks out the Mac minimum version argument into its own variable, MAC_FLAGS, in gcc.make, so it can be added independently in saproc.make and jsig.make. This prevents duplicate linker flags and C++-only flags being added to the C build for jsig and saproc.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8374948 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8374948: [8u] saproc & jsig builds add duplicate linker flags on Darwin/MacOS (Bug - P4 - Approved)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/742/head:pull/742
$ git checkout pull/742

Update a local copy of the PR:
$ git checkout pull/742
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/742/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 742

View PR using the GUI difftool:
$ git pr show -t 742

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/742.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into pr/740 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8374948: [8u] saproc & jsig builds add duplicate linker flags on Darwin/MacOS

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 04: Full (4951b8cb)
• 03: Full (faf44a2c)
• 02: Full - Incremental (4e5afd45)
• 01: Full - Incremental (8d804e1f)
• 00: Full (8d804e1f)

[openjdk]

@gnu-andrew Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[jerboaa]

This is hard to review as-is (139 changed files). Best to integrate #738 and then do a merge from master and it should look better.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8374948
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[gnu-andrew]

This is hard to review as-is (139 changed files). Best to integrate #738 and then do a merge from master and it should look better.

Yes, the change itself is tiny, but obviously it needed all the dependencies so there was actually a Mac build to test it on. It should look better now.

[jerboaa]

Looks good.

[openjdk]

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[gnu-andrew]

/approval request This fixes a bug in the saproc & jsig Makefiles on *BSD where the entire contents of LFLAGS were being added on Darwin only, rather than just what was required; the minimum MacOS version. This has gone unnoticed while the additional flags were just duplicates of flags already added by these Makefiles, but with the fix to add missing clang flags (JDK-8374899), it means a C++ compiler flag is being added to what is a C code build, causing a build failure. The change was reviewed by Severin Gehwolf and GHA testing shows this enables a working MacOS build there again. The risk is small, given it is specific to the build of the agent & jsig libraries on MacOS only, and manual verification of the build output from GHA shows that the same flags are still present from elsewhere.

[openjdk]

@gnu-andrew
8374948: The approval request has been created successfully.

[jerboaa]

/approve yes

[openjdk]

@jerboaa
8374948: The approval request has been approved.

[gnu-andrew]

/integrate

[openjdk]

Going to push as commit 08e617e.

[openjdk]

@gnu-andrew Pushed as commit 08e617e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.