8369996: Testcase java/net/Socket/B8312065.java fails on Mac, AIX and Solaris

[yanglong1010]

Hi,

Could I have a review of this patch ?

This patch limits the test for JDK-8312065 to run only on Linux.

The test for JDK-8312065 needs to build a native library to send signals to Java threads. I don't have Mac, AIX and Solaris devices. Limit the platform is the simplest way for now.

Thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8369996 needs maintainer approval

Issue

• JDK-8369996: Testcase java/net/Socket/B8312065.java fails on Mac, AIX and Solaris (Bug - P4 - Approved)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/768/head:pull/768
$ git checkout pull/768

Update a local copy of the PR:
$ git checkout pull/768
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/768/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 768

View PR using the GUI difftool:
$ git pr show -t 768

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/768.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[Copilot]

Pull request overview

Limits execution of the regression test for JDK-8312065 to Linux only, avoiding failures on platforms where the test’s native-library build/run path is currently not portable (e.g., macOS).

Changes:

• Change the jtreg @requires constraint from “non-Windows” to “Linux only” for B8312065.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[openjdk]

@yanglong1010 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8369996: Testcase java/net/Socket/B8312065.java fails on Mac, AIX and Solaris

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 5bf7359: 8380377: [8u] Problem list CAInterop.java#teliarootcav2
• e896646: 8379684: Bump update version of OpenJDK: 8u502
• cb21280: 8373476: (tz) Update Timezone Data to 2025c
• ... and 1 more: https://git.openjdk.org/jdk8u-dev/compare/001c609d45f0165c3514aede975122c2f65ba8fa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (dc026787)

[jerboaa]

This is fine, thanks!

[openjdk]

⚠️ @yanglong1010 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[yanglong1010]

/approval 8369996 request This patch limits the test for JDK-8312065 to run only on Linux. Maybe in the future somebody with devices steps up to fix the test on macos/aix/solaris. The risk is low. Thanks.

[openjdk]

@yanglong1010
8369996: The approval request has been created successfully.

[jerboaa]

/approve yes

[openjdk]

@jerboaa
8369996: The approval request has been approved.

[jerboaa]

@yanglong1010 Please integrate.

[yanglong1010]

/integrate

[openjdk]

@yanglong1010
Your change (at version dc02678) is now ready to be sponsored by a Committer.

[yanglong1010]

@jerboaa Sorry for the late integration. GitHub notified me that this PR was reviewed by a reviewer without write access. I thought another review from a reviewer with write access was needed. Based on my experience with the jdk-8u, this process can be rather slow, so I waited a few weeks and came back today. It seems this was my misunderstanding. Could you help sponsor this for me?