Rename Service label to control-plane: kruise-controller-manager#149
Rename Service label to control-plane: kruise-controller-manager#149aiyijing wants to merge 1 commit intoopenkruise:masterfrom
Conversation
Signed-off-by: aiyijing <aiyijing@live.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @aiyijing! It looks like this is your first PR to openkruise/charts 🎉 |
|
Hi there! The label control-plane: controller-manager is the default from Kubebuilder scaffolding, but it's too generic. This PR updates it to control-plane: kruise-controller-manager to make it specific to Kruise and avoid such conflicts. Thanks! |
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master. They are not published on branches.