feat: support scheduling fields in kruise helmHooks and kruise-game#162
Open
ylhyh wants to merge 2 commits intoopenkruise:masterfrom
Open
feat: support scheduling fields in kruise helmHooks and kruise-game#162ylhyh wants to merge 2 commits intoopenkruise:masterfrom
ylhyh wants to merge 2 commits intoopenkruise:masterfrom
Conversation
Changes involve: - Updating `versions/kruise-game/next/values.yaml` in `charts/kruise-game` to include the new fields. - Updating `versions/kruise-game/next/templates/manager.yaml` in `charts/kruise-game` to consume these values. - Updating `versions/kruise/next/values.yaml` in `charts/kruise` to include a section for hook scheduling (under `helmHooks` section). - Updating the finalizer job templates in `versions/kruise/next/templates/pre_delete_hook_job.yaml` to consume these values.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @ylhyh! It looks like this is your first PR to openkruise/charts 🎉 |
Member
|
can you also change the kruise-rollout chart ? |
Author
Done. I have added nodeAffinity and nodeSelector support while keeping the existing podAntiAffinity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes involve:
versions/kruise-game/next/values.yamlincharts/kruise-gameto include the new fields.versions/kruise-game/next/templates/manager.yamlincharts/kruise-gameto consume these values.versions/kruise/next/values.yamlincharts/kruiseto include a section for hook scheduling (underhelmHookssection).versions/kruise/next/templates/pre_delete_hook_job.yamlto consume these values.Which issue(s) this PR fixes:
Fixes #161
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
FYI, just commited to the "next" folder
Changes are automatically published when merged to
master. They are not published on branches.