-
Notifications
You must be signed in to change notification settings - Fork 596
Allow reactions included in depletion chain to be configured #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
drewejohnson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No major issues on my end. Would like to hear what @shimwell or other fusion people think
openmc/deplete/chain.py
Outdated
| reactions : iterable of str, optional | ||
| Transmutation reactions to include in the depletion chain, e.g., | ||
| `["(n,2n)", "(n,gamma)"]`. Note that fission is always included if | ||
| it is present. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps something could be added to this doc string so users are more aware of that useful list of reactions in chain.Reactions.keys()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion @shimwell. I've just pushed a commit that adds documentation of REACTIONS and references it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for that
|
That looks most useful. reactions using the same defaults as before but also allowing a much larger list to be added. Not sure I would have spotted that useful list of reactions available in chain.REACTIONS.keys() without seeing your example and reading the source code. Wondering if that could be hinted at in the documentation or docstring. |
|
Based on the feedback by @shimwell #1618 (comment) and the updated documentation 3d35cd3, this looks good to go. Thanks @paulromano and @shimwell! |
This pull request expands the list of (possible) transmutation reactions in the deplete/chain.py module. There is now a global dictionary,
REACTIONS, that contains all the necessary information for each transmutation reaction. To actually choose which reactions should be included in a depletion chain, theChain.from_endfmethod now has areactionsargument that takes an iterable of reaction names, e.g.["(n,2n)", "(n,3n)", "(n,gamma)"]. The default list of reactions is still the same as it was before.I've been able to use these capabilities to generate a depletion chain using TENDL-2019 with 36 reactions present (for fusion applications). The way it works is roughly:
A few other small fixes/changes:
replace_missingfunction is used to find a suitable replacement