Skip to content

improve path detection #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGijsbers merged 2 commits into from
Feb 12, 2021
Merged

improve path detection #1021

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b0345b
improve path detection
mfeurer Feb 4, 2021
233a6d9
simplify code a bit
mfeurer Feb 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 4 additions & 15 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,6 @@
logger.setLevel(logging.DEBUG)

file_list = []
directory = None

# finding the root directory of conftest.py and going up to OpenML main directory
# exploiting the fact that conftest.py always resides in the root directory for tests
static_dir = os.path.dirname(os.path.abspath(__file__))
logger.info("static directory: {}".format(static_dir))
while True:
if "openml" in os.listdir(static_dir):
break
static_dir = os.path.join(static_dir, "..")


def worker_id() -> str:
Expand All @@ -66,12 +56,11 @@ def read_file_list() -> List[str]:

:return: List[str]
"""
directory = os.path.join(static_dir, "tests/files/")
if worker_id() == "master":
logger.info("Collecting file lists from: {}".format(directory))
files = os.walk(directory)
this_dir = os.path.abspath(os.path.dirname(os.path.abspath(__file__)))
directory = os.path.join(this_dir, "..")
logger.info("Collecting file lists from: {}".format(directory))
file_list = []
for root, _, filenames in files:
for root, _, filenames in os.walk(directory):
for filename in filenames:
file_list.append(os.path.join(root, filename))
return file_list
Expand Down