Skip to content

Fix #1033: skip two unit tests on Windows #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 2 commits into from
Mar 26, 2021
Merged

Fix #1033: skip two unit tests on Windows #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2b113d
skip two unit tests on Windows
mfeurer Mar 25, 2021
3166f15
make tests less strict for Windows
mfeurer Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/test_openml/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ class TestConfig(openml.testing.TestBase):
@unittest.mock.patch("os.path.expanduser")
@unittest.mock.patch("openml.config.openml_logger.warning")
@unittest.mock.patch("openml.config._create_log_handlers")
@unittest.skipIf(os.name == "nt", "https://github.com/openml/openml-python/issues/1033")
def test_non_writable_home(self, log_handler_mock, warnings_mock, expanduser_mock):
with tempfile.TemporaryDirectory(dir=self.workdir) as td:
expanduser_mock.side_effect = (
Expand Down
4 changes: 3 additions & 1 deletion tests/test_runs/test_run_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1618,7 +1618,9 @@ def test__run_task_get_arffcontent_2(self, parallel_mock):
0.9655172413793104,
]
scores = [v for k, v in res[2]["predictive_accuracy"][0].items()]
self.assertSequenceEqual(scores, expected_scores, seq_type=list)
np.testing.assert_array_almost_equal(
scores, expected_scores, decimal=2 if os.name == "nt" else 7
)

@unittest.skipIf(
LooseVersion(sklearn.__version__) < "0.21",
Expand Down
1 change: 1 addition & 0 deletions tests/test_utils/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ def test_list_all_for_evaluations(self):
self.assertEqual(len(evaluations), required_size)

@unittest.mock.patch("openml.config.get_cache_directory")
@unittest.skipIf(os.name == "nt", "https://github.com/openml/openml-python/issues/1033")
def test__create_cache_directory(self, config_mock):
with tempfile.TemporaryDirectory(dir=self.workdir) as td:
config_mock.return_value = td
Expand Down