Skip to content

Don't fail when Parquet server can't be reached #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 1 commit into from
May 19, 2021
Merged

Don't fail when Parquet server can't be reached #1085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion openml/datasets/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import numpy as np
import arff
import pandas as pd
import urllib3

import xmltodict
from scipy.sparse import coo_matrix
Expand Down Expand Up @@ -425,7 +426,10 @@ def get_dataset(

arff_file = _get_dataset_arff(description) if download_data else None
if "oml:minio_url" in description and download_data:
parquet_file = _get_dataset_parquet(description)
try:
parquet_file = _get_dataset_parquet(description)
except urllib3.exceptions.MaxRetryError:
Copy link
Collaborator Author

@PGijsbers PGijsbers May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if I should be conservative here, or just catch all errors. Considering we haven't had any issues otherwise I went with the general best practice of only minimally catching exceptions.

Copy link
Collaborator

@mfeurer mfeurer May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

parquet_file = None
else:
parquet_file = None
remove_dataset_cache = False
Expand Down