Skip to content

Precommit update #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGijsbers merged 3 commits into from
Apr 14, 2022
Merged

Precommit update #1129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a359dd5
Correctly use regex to specify files
PGijsbers Mar 11, 2022
877c2ba
Add type hint
PGijsbers Mar 11, 2022
af43625
Add note of fixing pre-commit hook #1129
PGijsbers Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,20 @@ repos:
hooks:
- id: mypy
name: mypy openml
files: openml/*
files: openml/.*
- id: mypy
name: mypy tests
files: tests/*
files: tests/.*
- repo: https://gitlab.com/pycqa/flake8
rev: 3.8.3
hooks:
- id: flake8
name: flake8 openml
files: openml/*
files: openml/.*
additional_dependencies:
- flake8-print==3.1.4
- id: flake8
name: flake8 tests
files: tests/*
files: tests/.*
additional_dependencies:
- flake8-print==3.1.4
2 changes: 2 additions & 0 deletions doc/progress.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,12 @@ Changelog

0.13.0
~~~~~~
* FIX#1030: ``pre-commit`` hooks now no longer should issue a warning.
* FIX#1110: Make arguments to ``create_study`` and ``create_suite`` that are defined as optional by the OpenML XSD actually optional.
* MAIN#1088: Do CI for Windows on Github Actions instead of Appveyor.



0.12.2
~~~~~~

Expand Down
2 changes: 1 addition & 1 deletion openml/study/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def get_nested_ids_from_result_dict(key: str, subkey: str) -> Optional[List]:
) # type: BaseStudy

elif main_entity_type in ["tasks", "task"]:

tasks = cast("List[int]", tasks)
study = OpenMLBenchmarkSuite(
suite_id=study_id,
alias=alias,
Expand Down