Fixed issue #1125 by setting strip_whitespace=False in xmltodict.parse calls #1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… xmltodict.parse calls
Closed
Collaborator
|
Hi amastruserio, thanks for your contribution 🙏 |
Contributor
Author
|
Hi PGijsbers, happy to help. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
What does this PR implement/fix? Explain your changes.
Fixed issue #1125 that incorrectly formatted the whitespace on some feature categories. Added flag strip_whitespace=False on all xmltodict.parse() functions. The changes didn't raise any other visible issues in any of the unit tests, and appeared to work as expected.