Doc/type def

.pre-commit-config.yaml

@@ -19,14 +19,21 @@ repos:
         additional_dependencies:
           - types-requests
           - types-python-dateutil
+      - id: mypy
+        name: mypy type-def-check
+        files: openml/datasets/.*
+        additional_dependencies:
+          - types-requests
+          - types-python-dateutil
       - id: mypy
         name: mypy top-level-functions
         files: openml/_api_calls.py
         additional_dependencies:
           - types-requests
           - types-python-dateutil
         args: [ --disallow-untyped-defs, --disallow-any-generics,
-                --disallow-any-explicit, --implicit-optional ]
+                --disallow-any-explicit, --implicit-optional, --allow-redefinition]
+
   - repo: https://github.com/pycqa/flake8
     rev: 6.0.0
     hooks:

openml/base.py

@@ -46,7 +46,7 @@ def _entity_letter(cls) -> str:
         return cls.__name__.lower()[len("OpenML") :][0]
 
     @abstractmethod
-    def _get_repr_body_fields(self) -> List[Tuple[str, Union[str, int, List[str]]]]:
+    def _get_repr_body_fields(self) -> List[Tuple[str, Union[str, int, List[str], None]]]:
         """Collect all information to display in the __repr__ body.
 
         Returns

openml/datasets/data_feature.py

@@ -1,6 +1,6 @@
 # License: BSD 3-Clause
-
 from typing import List
+from prettyprinter import PrettyPrinter
 
 
 class OpenMLDataFeature(object):
@@ -59,11 +59,11 @@ def __init__(
         self.nominal_values = nominal_values
         self.number_missing_values = number_missing_values
 
-    def __repr__(self):
+    def __repr__(self) -> str:
         return "[%d - %s (%s)]" % (self.index, self.name, self.data_type)
 
-    def __eq__(self, other):
+    def __eq__(self, other: object) -> bool:
         return isinstance(other, OpenMLDataFeature) and self.__dict__ == other.__dict__
 
-    def _repr_pretty_(self, pp, cycle):
+    def _repr_pretty_(self, pp: PrettyPrinter, cycle: bool) -> None:
         pp.text(str(self))