Skip to content

Conversation

@LennartPurucker
Copy link
Contributor

Rel: #1136, #1125

@PGijsbers I still have not found a good way to fix the edge case where this change would require a cache reset.

I am also trying to figure out how to see if this breaks anything we do not know about (all tests pass).

Cache Reset

Relevant code:

def _read_features(features_file: Path) -> dict[int, OpenMLDataFeature]:
    features_pickle_file = Path(_get_features_pickle_file(str(features_file)))
    try:
        with features_pickle_file.open("rb") as fh_binary:
            return pickle.load(fh_binary)  # type: ignore  # noqa: S301

    except:  # noqa: E722
        with Path(features_file).open("r", encoding="utf8") as fh:
            features_xml_string = fh.read()

        features = _parse_features_xml(features_xml_string)

        with features_pickle_file.open("wb") as fh_binary:
            pickle.dump(features, fh_binary)

        return features

Let us discuss this in person.

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.07%. Comparing base (d3bb775) to head (6db7192).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
openml/datasets/functions.py 80.00% 2 Missing ⚠️
openml/evaluations/functions.py 75.00% 1 Missing ⚠️
openml/study/functions.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1363   +/-   ##
========================================
  Coverage    84.07%   84.07%           
========================================
  Files           38       38           
  Lines         5305     5305           
========================================
  Hits          4460     4460           
  Misses         845      845           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LennartPurucker LennartPurucker changed the title Fix: Strip Whitespace New PR fix: Strip Whitespace New PR Oct 15, 2024
@LennartPurucker
Copy link
Contributor Author

Closing this as a result of recent developments: #1125

@LennartPurucker
Copy link
Contributor Author

New: #1368

@LennartPurucker LennartPurucker deleted the add/strip_whitespace branch October 18, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants