Skip to content

also check dependencies for sklearn string #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 5 commits into from
Oct 16, 2019
Merged

also check dependencies for sklearn string #830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62095a2
also check dependencies for sklearn string
amueller Oct 15, 2019
ae9ae11
added test
amueller Oct 15, 2019
491127e
test for None
amueller Oct 15, 2019
98b2a94
Merge branch 'develop' into sklearn_extension_api
amueller Oct 16, 2019
9b6038d
be safe against dummy flow
amueller Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions openml/extensions/sklearn/extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,9 @@ def _is_cross_validator(self, o: Any) -> bool:

@classmethod
def _is_sklearn_flow(cls, flow: OpenMLFlow) -> bool:
if (getattr(flow, 'dependencies', None) is not None
and "sklearn" in flow.dependencies):
return True
if flow.external_version is None:
return False
else:
Expand Down
10 changes: 10 additions & 0 deletions tests/test_extensions/test_sklearn_extension/test_sklearn_extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,16 @@ def test_serialize_model(self):

self.assertEqual(check_dependencies_mock.call_count, 1)

def test_can_handle_flow(self):
openml.config.server = self.production_server

R_flow = openml.flows.get_flow(6794)
assert not self.extension.can_handle_flow(R_flow)
old_3rd_party_flow = openml.flows.get_flow(7660)
assert self.extension.can_handle_flow(old_3rd_party_flow)

openml.config.server = self.test_server

def test_serialize_model_clustering(self):
with mock.patch.object(self.extension, '_check_dependencies') as check_dependencies_mock:
model = sklearn.cluster.KMeans()
Expand Down