Skip to content

Adding option to print logs during an api call #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 6 commits into from
Nov 11, 2019
Merged

Adding option to print logs during an api call #833

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aa40c97
Adding option to print logs during an api call
Neeratyoy Oct 15, 2019
4fe709b
Adding timing to log and changing string interpolation
Neeratyoy Oct 16, 2019
7dc8d45
Improving logging and timing of api calls
Neeratyoy Oct 16, 2019
050a86c
Merge branch 'develop' into git_api_call_logging
Neeratyoy Oct 17, 2019
535d28e
PEP8
mfeurer Nov 11, 2019
f98aaf4
PEP8
mfeurer Nov 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions openml/_api_calls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import time
from typing import Dict
import logging
import requests
import warnings

import xmltodict
from typing import Dict

from . import config
from .exceptions import (OpenMLServerError, OpenMLServerException,
Expand Down Expand Up @@ -43,13 +43,22 @@ def _perform_api_call(call, request_method, data=None, file_elements=None):
url += call

url = url.replace('=', '%3d')

logging.info('Starting [%s] request for the URL %s', request_method, url)
start = time.time()
if file_elements is not None:
if request_method != 'post':
raise ValueError('request method must be post when file elements '
'are present')
return _read_url_files(url, data=data, file_elements=file_elements)
return _read_url(url, request_method, data)
response = _read_url_files(url, data=data, file_elements=file_elements)
else:
response = _read_url(url, request_method, data)
logging.info(
'%.7fs taken for [%s] request for the URL %s',
time.time() - start,
request_method,
url,
)
return response


def _file_id_to_url(file_id, filename=None):
Expand Down