-
-
Notifications
You must be signed in to change notification settings - Fork 212
Add debug output #860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug output #860
Changes from all commits
c521b07
0d3fef1
9ceb4e9
ed15c98
a38e484
aed857f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,7 +79,7 @@ def _wait_for_processed_run(self, run_id, max_waiting_time_seconds): | |
| if len(run.evaluations) > 0: | ||
| return | ||
| else: | ||
| time.sleep(10) | ||
| time.sleep(3) | ||
| raise RuntimeError('Could not find any evaluations! Please check whether run {} was ' | ||
| 'evaluated correctly on the server'.format(run_id)) | ||
|
|
||
|
|
@@ -1120,8 +1120,13 @@ def test_get_run(self): | |
| ) | ||
|
|
||
| def _check_run(self, run): | ||
| # This tests that the API returns seven entries for each run | ||
| # Check out https://openml.org/api/v1/xml/run/list/flow/1154 | ||
| # They are run_id, task_id, task_type_id, setup_id, flow_id, uploader, upload_time | ||
| # error_message and run_details exist, too, but are not used so far. We need to update | ||
| # this check once they are used! | ||
| self.assertIsInstance(run, dict) | ||
| self.assertEqual(len(run), 7) | ||
| assert len(run) == 7, str(run) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you please explain in comments why 7? is not clear from the (direct) context
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's the amount of entries per run returned by the API: https://openml.org/api/v1/xml/run/list/flow/1154
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just pushed a commit explaining this. I will merge once the tests are through.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good. I am not sure if we should really check this, as this is flexible for extension. But in those cases we can adjust the unit tests as well |
||
|
|
||
| def test_get_runs_list(self): | ||
| # TODO: comes from live, no such lists on test | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.