Rename arguments of list_evaluations to indicate they expect lists of ids #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PGijsbers
requested changes
Apr 20, 2020
Collaborator
PGijsbers
left a comment
PGijsbers
left a comment
There was a problem hiding this comment.
The changes you made are good, I have one nit-picky name change.
That said, it's not complete. The unit tests are failing, because you did not update them in your changes. Click on 'details' for Travis CI and inspect why unit tests are failing. You'll see that the unit tests need their parameters updated too. There's is also feedback on code formatting, and a small mistake introduced by not renaming flow to flows when it is used in the function body.
| setup_chunks = np.array_split(ary=evals['setup_id'].unique(), | ||
| indices_or_sections=((length - 1) // N) + 1) | ||
| setups = pd.DataFrame() | ||
| setupp = pd.DataFrame() |
Collaborator
There was a problem hiding this comment.
Maybe use setup_data instead.
Contributor
Author
|
Updated after new version - https://github.com/openml/openml-python/pull/933 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#804