Skip to content

Prevent Ai chats from step settings to appear in Ai Assistant#1622

Merged
ravikiranvm merged 1 commit intomainfrom
ops-3058
Nov 17, 2025
Merged

Prevent Ai chats from step settings to appear in Ai Assistant#1622
ravikiranvm merged 1 commit intomainfrom
ops-3058

Conversation

@ravikiranvm
Copy link
Contributor

@ravikiranvm ravikiranvm commented Nov 17, 2025

Fixes OPS-3058.
Deployed to UX

Additional Notes

@linear
Copy link

linear bot commented Nov 17, 2025

@sonarqubecloud
Copy link

@ravikiranvm ravikiranvm marked this pull request as ready for review November 17, 2025 10:51
Copilot AI review requested due to automatic review settings November 17, 2025 10:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prevents AI chats initiated from step settings from appearing in the AI Assistant by filtering chat persistence based on chat mode.

Key Changes:

  • Added a guard condition in the onFinish callback to skip name generation and chat persistence for non-Agent chat modes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

toast(errorToast);
},
onFinish: async () => {
if (chatMode !== ChatMode.Agent) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prevents calling chat-name endpoint to generate a chat name for AI conversations made from step-settings. When a chat doesn't have a name, it wouldn't be included in the chat history list.

@ravikiranvm ravikiranvm merged commit 212990c into main Nov 17, 2025
22 checks passed
@ravikiranvm ravikiranvm deleted the ops-3058 branch November 17, 2025 14:49
sg-doc-holiday bot added a commit that referenced this pull request Nov 19, 2025
Create a root CHANGELOG.md and add the 0.6.7 entry following the style guide: emoji category headers, concise bullets, and a compare link. Entries are grounded by commits #1636, #1637, #1600, #1622, #1635, and #1577.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments