Skip to content

Conversation

@lazappi
Copy link
Member

@lazappi lazappi commented Oct 31, 2024

Describe your changes

Adds the Universal Cell Embeddings foundation model as a method

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@lazappi lazappi requested a review from rcannood October 31, 2024 11:15
rename_keys: 'input_dataset:output_dataset;input_solution:output_solution'
output_state: "state.yaml"
publish_dir: "$publish_dir"
settings: '{"methods_exclude": ["uce"]}'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I excluded UCE from the local benchmark scripts because it requires more memory than is allowed by the local labels config

Comment on lines +15 to +24
# Code has hardcoded paths that only work correctly inside the UCE directory
if os.path.isdir("UCE"):
# For executable we can work inside the UCE directory
os.chdir("UCE")
else:
# For Nextflow we need to copy files to the Nextflow working directory
print(">>> Copying UCE files to local directory...", flush=True)
import shutil

shutil.copytree("/workspace/UCE", ".", dirs_exist_ok=True)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite hacky but it was the only way I could get it to work. Happy to hear other suggestions.

Copy link
Contributor

@KaiWaldrant KaiWaldrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcannood rcannood merged commit 7e0b381 into main Nov 8, 2024
lazappi added a commit that referenced this pull request Nov 22, 2024
…PRINT

* origin/main:
  fix repository name
  Migrate from core to openproblems (#11)
  fix broken urls
  fix wf
  Pre-filter batches in hvg overlap metric (#9)
  Adjust resources (#10)
  Add scGPT (#8)
  Add UCE method (#7)
  Add Geneformer (#6)
  fix submodule
  Update common submodule
@lazappi lazappi deleted the feature/no-ref/add-UCE branch November 22, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants