Fix style precedence in DefaultProjectParser#426
Merged
Conversation
Reorder style application so configured styles are added after autodetected styles, ensuring they take precedence under the corrected NamedStyles.merge() behavior.
sambsnyd
approved these changes
Feb 26, 2026
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
The upstream UpdateGradleWrapper recipe now uses downloads.gradle.org instead of services.gradle.org.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes failing tests caused by upstream OpenRewrite change to
NamedStyles.merge()semantics inThat fix now correctly implements "last wins" precedence, but the gradle plugin was adding configured styles first and autodetected styles second, causing autodetected styles to incorrectly override configured ones.
Changes
Moved configured style application from
addProvenance()to a newapplyConfiguredStyles()method that runs afterapplyAutodetected(). This ensures configured styles take precedence as intended.Test Plan
reformatToIntelliJStylenow correctly applies IntelliJ 4-space indentation stylemergeConfiguredAndAutodetectedStylesnow correctly applies tab indentation style