Fix PrintStackTraceToLogError breaking stacktrace-to-string methods#282
Merged
Fix PrintStackTraceToLogError breaking stacktrace-to-string methods#282
Conversation
The recipe was transforming all `printStackTrace()` calls including those that intentionally capture a stack trace to a string via StringWriter/ PrintWriter. Now only transforms no-arg calls or calls with System.err/ System.out arguments. Fixes #281
mergify bot
added a commit
to robfrank/linklift
that referenced
this pull request
Mar 10, 2026
…rom 3.24.0 to 3.25.0 [skip ci] Bumps [org.openrewrite.recipe:rewrite-logging-frameworks](https://github.com/openrewrite/rewrite-logging-frameworks) from 3.24.0 to 3.25.0. Release notes *Sourced from [org.openrewrite.recipe:rewrite-logging-frameworks's releases](https://github.com/openrewrite/rewrite-logging-frameworks/releases).* > 3.25.0 > ------ > > What's Changed > -------------- > > * Add StringFormat, MessageFormat, and RemoveUnnecessaryLogLevelGuards SLF4J recipes. by [`@motlin`](https://github.com/motlin) in [openrewrite/rewrite-logging-frameworks#280](https://redirect.github.com/openrewrite/rewrite-logging-frameworks/pull/280) > * Fix PrintStackTraceToLogError breaking stacktrace-to-string methods by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-logging-frameworks#282](https://redirect.github.com/openrewrite/rewrite-logging-frameworks/pull/282) > > **Full Changelog**: <openrewrite/rewrite-logging-frameworks@v3.24.0...v3.25.0> Commits * [`6618dfa`](openrewrite/rewrite-logging-frameworks@6618dfa) Fix PrintStackTraceToLogError breaking stacktrace-to-string methods ([#282](https://redirect.github.com/openrewrite/rewrite-logging-frameworks/issues/282)) * [`2f457be`](openrewrite/rewrite-logging-frameworks@2f457be) Add StringFormat, MessageFormat, and RemoveUnnecessaryLogLevelGuards SLF4J re... * See full diff in [compare view](openrewrite/rewrite-logging-frameworks@v3.24.0...v3.25.0) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PrintStackTraceToLogErrorwas blindly transforming allprintStackTrace()calls, including those that capture a stack trace to a string viaStringWriter/PrintWriterAdded a whitelist guard: when
printStackTracehas an argument, only transform if the argument isSystem.errorSystem.outAdded a test reproducing the issue from
PrintStackTraceToLogErrorbreaks stacktrace-to-string method #281 (thegetStackTrace(Throwable)pattern usingStringWriter/PrintWriter)Fixes
PrintStackTraceToLogErrorbreaks stacktrace-to-string method #281Test plan
doesNotReplacePrintStackTraceWithPrintWriterArgumentasserts no transformation forPrintWriterargumentsuseSlf4jandsupportLombokLogAnnotationstests still pass (they verifySystem.err/System.outargs are transformed)./gradlew checkpasses