Add integration test for JDK 25 Lombok LinkageError#1109
Merged
Conversation
Verifies that the rewrite plugin can parse JDK 25 projects using Lombok on comment-free main sources with commented test sources, which previously triggered a LinkageError in JavaUnrestrictedClassLoader.defineClass(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
Verified separately as we don't yet run CI on Java 25, and due to Kotlin 1.9 can't yet: |
mergify bot
added a commit
to robfrank/linklift
that referenced
this pull request
Feb 26, 2026
… 6.29.0 to 6.30.0 [skip ci] Bumps [org.openrewrite.maven:rewrite-maven-plugin](https://github.com/openrewrite/rewrite-maven-plugin) from 6.29.0 to 6.30.0. Release notes *Sourced from [org.openrewrite.maven:rewrite-maven-plugin's releases](https://github.com/openrewrite/rewrite-maven-plugin/releases).* > 6.30.0 > ------ > > What's Changed > -------------- > > * Add integration test for JDK 25 Lombok LinkageError by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-maven-plugin#1109](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1109) > * chore(ci): bump org.junit:junit-bom from 6.0.2 to 6.0.3 by [`@dependabot`](https://github.com/dependabot)[bot] in [openrewrite/rewrite-maven-plugin#1111](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1111) > * chore(ci): bump io.micrometer:micrometer-core from 1.16.2 to 1.16.3 by [`@dependabot`](https://github.com/dependabot)[bot] in [openrewrite/rewrite-maven-plugin#1112](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1112) > * chore(ci): bump org.apache.maven.plugins:maven-failsafe-plugin from 3.5.4 to 3.5.5 by [`@dependabot`](https://github.com/dependabot)[bot] in [openrewrite/rewrite-maven-plugin#1114](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1114) > * Add generateRecipeCsv goal by [`@Jenson3210`](https://github.com/Jenson3210) in [openrewrite/rewrite-maven-plugin#1113](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1113) > > **Full Changelog**: <openrewrite/rewrite-maven-plugin@v6.29.0...v6.30.0> Commits * [`a131783`](openrewrite/rewrite-maven-plugin@a131783) [maven-release-plugin] prepare release v6.30.0 * [`319a5e7`](openrewrite/rewrite-maven-plugin@319a5e7) Bump rewrite.version property * [`ab0a77a`](openrewrite/rewrite-maven-plugin@ab0a77a) Add generateRecipeCsv goal ([#1113](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1113)) * [`be51df2`](openrewrite/rewrite-maven-plugin@be51df2) chore(ci): bump org.apache.maven.plugins:maven-failsafe-plugin ([#1114](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1114)) * [`fc41141`](openrewrite/rewrite-maven-plugin@fc41141) Update SDKMan Java version * [`d09e235`](openrewrite/rewrite-maven-plugin@d09e235) chore(ci): bump io.micrometer:micrometer-core from 1.16.2 to 1.16.3 ([#1112](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1112)) * [`99164e9`](openrewrite/rewrite-maven-plugin@99164e9) chore(ci): bump org.junit:junit-bom from 6.0.2 to 6.0.3 ([#1111](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1111)) * [`3ba6e5a`](openrewrite/rewrite-maven-plugin@3ba6e5a) Add integration test for JDK 25 LinkageError with Lombok ([#1109](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1109)) * [`b5138fc`](openrewrite/rewrite-maven-plugin@b5138fc) Bump rewrite.version property * [`487a4e4`](openrewrite/rewrite-maven-plugin@487a4e4) Bump rewrite.version property * Additional commits viewable in [compare view](openrewrite/rewrite-maven-plugin@v6.29.0...v6.30.0) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an integration test that reproduces the JDK 25
LinkageErrorinJavaUnrestrictedClassLoader.defineClass()when parsing Lombok projectsTest project:
@Data/@Buildermain sources with no comments + test sources with//commentsIncludes
.mvn/jvm.configwith--add-exportsflags required for the fix to workTest is gated with
@EnabledForJreRange(min = JRE.JAVA_25)Depends on Fix JDK 25 LinkageError in JavaUnrestrictedClassLoader rewrite#6736 for the code fix in
JavaUnrestrictedClassLoader.Test plan
mvn verify -Dit.test="RewriteRunIT#lombok_jdk25_linkage_error"passes on JDK 25 with the rewrite snapshot🤖 Generated with Claude Code