Skip to content

Fix GHSA-6fmv-xxpf-w3cw: pin plexus-utils 3.6.1 and suppress false positive#1138

Merged
timtebeek merged 1 commit intomainfrom
tim/bump-plexus-utils
Apr 8, 2026
Merged

Fix GHSA-6fmv-xxpf-w3cw: pin plexus-utils 3.6.1 and suppress false positive#1138
timtebeek merged 1 commit intomainfrom
tim/bump-plexus-utils

Conversation

@timtebeek
Copy link
Copy Markdown
Member

@timtebeek timtebeek commented Apr 8, 2026

Summary

Addresses GHSA-6fmv-xxpf-w3cw (Zip Slip in plexus-utils Expand class).

  • Move plexus-utils from a direct compile dependency to <dependencyManagement>, pinned at 3.6.1 which contains the fix. The only classes used (Xpp3Dom, MXSerializer) are already provided by the existing plexus-xml:4.1.1 dependency.
  • Add a temporary OWASP dependency-check suppression (expires 2026-05-08) for CVE-2025-67030, since the advisory currently lists all versions below 4.0.3 as affected — a false positive for 3.6.1. A correction has been submitted to the advisory.

Test plan

  • mvn compile passes
  • All 15 tests pass

@Jenson3210
Copy link
Copy Markdown
Contributor

Are we confident about this change? Shannon added this back. 3.6.1 is a backpatch which is not vulnerable but just not known by the vulnerability database.

Kevin mentioned maven3 is not compatible with 4.x

@timtebeek
Copy link
Copy Markdown
Member Author

Was that not for a different vulnerability? Since this lists anything below 4.0.3 as vulnerable:

My plan was to merge this and run the scan again to verify we don't pull in this version anymore transitively.

@Jenson3210
Copy link
Copy Markdown
Contributor

@timtebeek timtebeek force-pushed the tim/bump-plexus-utils branch from 586819a to 7bfb2a5 Compare April 8, 2026 16:51
@timtebeek timtebeek changed the title Remove plexus-utils dependency (GHSA-6fmv-xxpf-w3cw) Remove direct plexus-utils dependency; pin to 4.0.3 via dependencyManagement Apr 8, 2026
@timtebeek timtebeek force-pushed the tim/bump-plexus-utils branch from 7bfb2a5 to 62e7589 Compare April 8, 2026 16:52
@timtebeek timtebeek changed the title Remove direct plexus-utils dependency; pin to 4.0.3 via dependencyManagement Remove direct plexus-utils dependency; pin to 3.6.1 via dependencyManagement Apr 8, 2026
@github-project-automation github-project-automation Bot moved this from In Progress to Ready to Review in OpenRewrite Apr 8, 2026
@timtebeek timtebeek force-pushed the tim/bump-plexus-utils branch from 62e7589 to e863e42 Compare April 8, 2026 16:55
@timtebeek timtebeek changed the title Remove direct plexus-utils dependency; pin to 3.6.1 via dependencyManagement Fix GHSA-6fmv-xxpf-w3cw: pin plexus-utils 3.6.1 and suppress false positive Apr 8, 2026
@timtebeek
Copy link
Copy Markdown
Member Author

Hmm; thanks! So then the issue appears to be slightly different: 3.6.1 already contains the fix, and we should continue to have that here to override the 3.6.0 coming in transitively.

I've proposed an upstream fix as well then

@timtebeek
Copy link
Copy Markdown
Member Author

mvn dependency:tree now shows 3.6.1 as provided, instead of as bundled previously:

[INFO] +- org.apache.maven:maven-plugin-api:jar:3.9.14:provided
[INFO] |  +- org.apache.maven:maven-artifact:jar:3.9.14:provided
[INFO] |  +- org.eclipse.sisu:org.eclipse.sisu.plexus:jar:1.0.0:provided
[INFO] |  +- org.codehaus.plexus:plexus-utils:jar:3.6.1:provided
[INFO] |  \- org.codehaus.plexus:plexus-classworlds:jar:2.9.0:provided

@timtebeek timtebeek merged commit 030f345 into main Apr 8, 2026
1 check passed
@timtebeek timtebeek deleted the tim/bump-plexus-utils branch April 8, 2026 17:09
@github-project-automation github-project-automation Bot moved this from Ready to Review to Done in OpenRewrite Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants