Add linking capability (to Read app) #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcstober
changed the title
marcstober
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds linking capability to the Read app, in the same way it already works in the Verse app.
I attempted to match the Verse app as much as possible. This adds some duplicated code between the Read and Verse apps, but that seemed to already be the approach used to maintain these two apps. There are some other things I might have done differently if making this from scratch (like updating
window.locationautomatically when a user changes the drop-down value, or usinglet/constin new development) but my goal here was to be consistent with the existing Verse app with minimal other changes.The one change a user would notice (besides the new functionality) is that the read app no longer opens by default to Haggai, but to Genesis. There was a comment (I removed) that opening by default to Haggai was for testing, and I thought it made sense to match the functionality of Verse app (which defaults to Genesis).