fix: vis editor empty state#11613
Conversation
❌ Entry Too LongEntry is 102 characters long, which is 2 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
|
Failed to generate code suggestions for PR |
|
Failed to generate code suggestions for PR |
✅ All unit and integration tests passing
|
legacy discover app Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
d9ac633 to
a15cd46
Compare
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11613 +/- ##
===========================================
- Coverage 61.58% 0 -61.59%
===========================================
Files 4995 0 -4995
Lines 137542 0 -137542
Branches 23901 0 -23901
===========================================
- Hits 84707 0 -84707
+ Misses 46692 0 -46692
+ Partials 6143 0 -6143
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-3.6 3.6
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-3.6
# Create a new branch
git switch --create backport/backport-11613-to-3.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e11799fff92a9187c71c224d26f0c5203d793379
# Push it to GitHub
git push --set-upstream origin backport/backport-11613-to-3.6
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-3.6Then, create a pull request where the |
* fix: visualization editor should not use empty state components from legacy discover app --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
* fix: visualization editor should not use empty state components from legacy discover app --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
Use visualization editor specific empty state component instead of importing from legacy discover app
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration