-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Closed
Labels
Storage:RemoteenhancementEnhancement or improvement to existing feature or requestEnhancement or improvement to existing feature or request
Description
Is your feature request related to a problem? Please describe
As part of shallow snapshot optimisations, we are introducing timestamp based implicit locking support. This feature will be called Timestamp Pinning in remote backed storage. When a timestamp is pinned, remote store garbage collectors will skip deleting data corresponding to the timestamp.
Describe the solution you'd like
As part of this solution, we need following changes to segment store garbage collection
- Each data node keeps an in-memory data structure
remote_store_pinned_timestamps(this is updated regularly as part of [Timestamp Pinning in Remote Store] Scheduler to fetch pinned timestamp list from remote store #15062) - If the last update time of
remote_store_pinned_timestampsis > X mins, skip garbage collection. - Fetch metadata files in sorted order (which generally is reverse-chronological order but not always)
- If timestamp of a metadata file
md1is >pinned_timestamp_aand the timestamp of next metadata filemd2<=pinned_timestamp_aaddmd2topinned_metadata_files - Skip deletion of metadata files in
pinned_metadata_filesand corresponding data files
Related component
Storage:Remote
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Storage:RemoteenhancementEnhancement or improvement to existing feature or requestEnhancement or improvement to existing feature or request
Type
Projects
Status
✅ Done