-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Add alternative usage for the configuration that contains "blacklist/whitelist" terminology #1547
Copy link
Copy link
Closed
Labels
>breakingIdentifies a breaking change.Identifies a breaking change.enhancementEnhancement or improvement to existing feature or requestEnhancement or improvement to existing feature or requestv2.0.0Version 2.0.0Version 2.0.0
Description
Is your feature request related to a problem? Please describe.
Replace "blacklist/whitelist" terminology in configurations, where the backwards compatibility will be impacted.
A part of #1483
Describe the solution you'd like
- Replace the old usages that having "blacklist/whitelist" in configurations with "denylist/allowlist", then create duplicate usages with the old terminology for backwards compatibility (including fallback logic to fallback to settings with the new name).
- Add tests to check both old and new usages of the configurations.
- Add proper deprecation notice to the old usages.
Describe alternatives you've considered
None.
Additional context
Locations of "blacklist/whitelist" in APIs and configurations:
Settings
1 reindex.remote.whitelist
Code: https://github.com/opensearch-project/OpenSearch/blob/1.0.0/modules/reindex/src/main/java/org/opensearch/index/reindex/TransportReindexAction.java#L60
The guide for plugins can be a reference: https://github.com/opensearch-project/opensearch-plugins/blob/ece53bf9e93403272726eb6087ed98f9c821502b/UPGRADING.md#settings
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
>breakingIdentifies a breaking change.Identifies a breaking change.enhancementEnhancement or improvement to existing feature or requestEnhancement or improvement to existing feature or requestv2.0.0Version 2.0.0Version 2.0.0