-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[Feature Request] Remove transport-nio plugin #16887
Copy link
Copy link
Closed
Labels
>breakingIdentifies a breaking change.Identifies a breaking change.LibrariesLucene Upgrades and Libraries, Any 3rd party library that Core depends on, ex: nebula; team is respoLucene Upgrades and Libraries, Any 3rd party library that Core depends on, ex: nebula; team is respoenhancementEnhancement or improvement to existing feature or requestEnhancement or improvement to existing feature or requestv3.0.0Issues and PRs related to version 3.0.0Issues and PRs related to version 3.0.0
Metadata
Metadata
Assignees
Labels
>breakingIdentifies a breaking change.Identifies a breaking change.LibrariesLucene Upgrades and Libraries, Any 3rd party library that Core depends on, ex: nebula; team is respoLucene Upgrades and Libraries, Any 3rd party library that Core depends on, ex: nebula; team is respoenhancementEnhancement or improvement to existing feature or requestEnhancement or improvement to existing feature or requestv3.0.0Issues and PRs related to version 3.0.0Issues and PRs related to version 3.0.0
Is your feature request related to a problem? Please describe
The transport-nio plugin provides an alternative to Netty for the network framework used by both node-to-node communication (transport) and client-to-server communication (http). This plugin (and library
libs/nio) make up about 8500 lines of Java code that must be maintained. To my knowledge, there is no scenario in which the nio plugin should be used in place of the Netty-based implementation. We should remove this plugin in order to remove effectively dead code and reduce the number of configuration options available to users.This is a breaking change so it would be done as a part of the next major version release.
Describe the solution you'd like
Related component
Libraries
Describe alternatives you've considered
The alternative is to keep maintaining this code
Additional context
See some additional discussion here:
I do not believe the stated friction points with Netty are still applicable.
Lines of code count from
cloc: