Skip to content

Introduce SecureHttpTransportParameters experimental API (to complement SecureTransportParameters counterpart)#18572

Merged
reta merged 1 commit intoopensearch-project:mainfrom
reta:issue-18559
Jun 20, 2025
Merged

Introduce SecureHttpTransportParameters experimental API (to complement SecureTransportParameters counterpart)#18572
reta merged 1 commit intoopensearch-project:mainfrom
reta:issue-18559

Conversation

@reta
Copy link
Copy Markdown
Contributor

@reta reta commented Jun 20, 2025

Description

Introduce SecureHttpTransportParameters experimental API (to complement SecureTransportParameters counterpart). The way we configure SSL Context in Reactor Netty 4 transport is not very clean and turned out to be fragile. By introducing SecureHttpTransportParameters (similarly with SecureTransportParameters), the transport could be configured in straightforward way.

Related Issues

Towards #18559

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta requested a review from a team as a code owner June 20, 2025 22:21
@reta reta added bug Something isn't working and removed skip-changelog labels Jun 20, 2025
…nt SecureTransportParameters counterpart)

Signed-off-by: Andriy Redko <drreta@gmail.com>
@reta
Copy link
Copy Markdown
Contributor Author

reta commented Jun 20, 2025

@andrross @cwperks if you have a second, small pull request to add SecureHttpTransportParameters (and add javadoc to SecureTransportParameters), thank you

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 0fed867: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.70%. Comparing base (7c8f01b) to head (0fed867).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../plugins/DefaultSecureHttpTransportParameters.java 0.00% 7 Missing ⚠️
...h/plugins/SecureHttpTransportSettingsProvider.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18572      +/-   ##
============================================
+ Coverage     72.68%   72.70%   +0.01%     
+ Complexity    68130    68116      -14     
============================================
  Files          5540     5541       +1     
  Lines        313379   313387       +8     
  Branches      45472    45472              
============================================
+ Hits         227785   227835      +50     
+ Misses        67070    66981      -89     
- Partials      18524    18571      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reta reta merged commit 63921b8 into opensearch-project:main Jun 20, 2025
32 of 33 checks passed
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
…nt SecureTransportParameters counterpart) (opensearch-project#18572)

Signed-off-by: Andriy Redko <drreta@gmail.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
…nt SecureTransportParameters counterpart) (opensearch-project#18572)

Signed-off-by: Andriy Redko <drreta@gmail.com>
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Aug 5, 2025
…nt SecureTransportParameters counterpart) (opensearch-project#18572)

Signed-off-by: Andriy Redko <drreta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working v3.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants